Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acb/with docker caching #4064

Merged
merged 2 commits into from
May 3, 2024
Merged

Acb/with docker caching #4064

merged 2 commits into from
May 3, 2024

Conversation

alexcb
Copy link
Collaborator

@alexcb alexcb commented Apr 26, 2024

Introduces a new WITH DOCKER --cache-id=<name> flag, which when
specified will cache the daya layers from the docker data-root
between runs, even when dependencies have changed.

Note that the docker image tags are NOT cached; and a user will still
have to re-load the image (via the WITH DOCKER --load or --pull flags);
however, since the data layers are cached, the re-tagging should be much
faster.

fixes #3399 #3485

@alexcb alexcb force-pushed the acb/with-docker-caching branch 4 times, most recently from 2b6c37c to 88f56cd Compare April 26, 2024 21:51
@alexcb alexcb marked this pull request as ready for review April 26, 2024 22:06
@alexcb alexcb requested a review from a team as a code owner April 26, 2024 22:06
buildkitd/dockerd-wrapper.sh Outdated Show resolved Hide resolved
buildkitd/dockerd-wrapper.sh Outdated Show resolved Hide resolved
buildkitd/dockerd-wrapper.sh Outdated Show resolved Hide resolved
@alexcb alexcb enabled auto-merge (squash) April 29, 2024 18:13
alexcb added 2 commits May 2, 2024 18:03
Introduces a new `WITH DOCKER --cache-id=<name>` flag, which when
specified will cache the daya layers from the docker data-root
between runs, even when dependencies have changed.

Note that the docker image tags are NOT cached; and a user will still
have to re-load the image (via the WITH DOCKER --load or --pull flags);
however, since the data layers are cached, the re-tagging should be much
faster.
@alexcb alexcb merged commit 3b98af4 into main May 3, 2024
102 of 103 checks passed
@alexcb alexcb deleted the acb/with-docker-caching branch May 3, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

WITH DOCKER with cached docker root dir
2 participants