Skip to content

Commit

Permalink
fix gefs tests (blaylockbk#100)
Browse files Browse the repository at this point in the history
  • Loading branch information
blaylockbk committed Jan 6, 2023
1 parent e7eb30a commit 14d154e
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
4 changes: 4 additions & 0 deletions herbie/models/gefs.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ def template(self):
"chem.25": "Chemistry fields on 0.25 degree grid",
}

if self.product is None:
# Just select the first PRODUCT as default
self.product = list(self.PRODUCTS)[0]

if self.product == "wave":
if self.member == "spr":
self.member = "spread"
Expand Down
15 changes: 14 additions & 1 deletion tests/test_gefs.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,22 @@

def test_gefs():
H = Herbie(
"2017-03-14",
"2023-01-01 06:00",
model="gefs",
fxx=12,
member="mean",
save_dir=save_dir,
)

assert H.grib, "GEFS grib2 file not found"
assert H.idx, "GEFS index file not found"


def test_gefs_reforecast():
H = Herbie(
"2017-03-14",
model="gefs_reforecast",
fxx=12,
member=0,
variable_level="tmp_2m",
save_dir=save_dir,
Expand Down

0 comments on commit 14d154e

Please sign in to comment.