-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using meaningful column/field names #54
Comments
Dear @amotl , I had mainly left those "data column names" untouched because I'd have a hard time choosing the right names for the values. There are those given names by DWD which are sometimes as long as a sentence which is also not really an option. Furthermore when extending the column names, the data becomes hardly printable as for data which has several parameters, this would easily span over the whole screen, thus the dataframe is hardly readable anymore. I'd prefer an opt in solution. Putting the full name also wouldn't be a problem if we'd melt the DataFrame (could also be opt in). What do you think? |
Dear Benjamin,
I see. Maybe @wetterfrosch and I can work on that aspect to establish reasonable names here.
Your wish is my command. I've added an option May I also suggest to use lowercase column names on the matter of #55? With kind regards, |
Thank you, I merged the PR. Column names may also be lowercase as you wish. |
Thanks again!
Shall we make all things on the right hand side of column_names_enumeration.py lowercase then? |
Yes, sure! |
After completing the list for the daily resolution, we should expand the list of column names for the 10_minutes and hourly resolutions next, see panodata/dwdweather2#13 (comment). |
I will try and setup up the names for the whole set of parameters. I already know that some values are not that clear, and with those I'll come back to you! |
Thanks! Borrowing from
|
Please check out the new branch https://github.com/earthobservations/wetterdienst/tree/more-meaningful-column-names I added all column names and had also added a function to create an individual mapping based on some anomalies within "kl" parameter, that has two quality flags within one file. I still had some issues with these parameters:
Maybe we can discuss those. |
Dear Benjamin and Daniel,
for starting a discussion around assigning meaningful English names to meteorological short identifiers, I wanted to humbly point out eaaf936 coming from our PR #55.
We had similar things within the knowledgebase module knowledge.py of
dwdweather2
and recognized you also already started to put efforts into the aspect of appropriately mapping DWD-specific original parameters, names and such to identifiers which are more suitable for human consumption.So, we would like to ask you if you appreciate the approach to expand that very aspect on all field names available?
With kind regards,
Andreas.
The text was updated successfully, but these errors were encountered: