Refactor index caching -> Remove monkeypatch for fsspec #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gutzbenj
force-pushed
the
gutzbenj/cache
branch
2 times, most recently
from
025a362
to
49751a8
Compare
|
Hi @gutzbenj, thanks for the quick turnaround on this! The new approach is exactly what I was talking about in my comment on the other PR! This saves me from having to carefully un- and then re-patch |
|
You're right though the way it has to be done is currently not so nice (overwriting an existing attribute manually...). Still cleaner then before :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @provinzkraut ,
thanks for the pushing! Got it to work much nicer now! Still will be looking into the fsspec PR to get it officially as a feature there.