Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedlist #3

Merged
merged 66 commits into from
Sep 22, 2013
Merged

Feedlist #3

merged 66 commits into from
Sep 22, 2013

Conversation

tribela
Copy link
Member

@tribela tribela commented Aug 2, 2013

branch to feedlist

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling c37beac on Kjwon15:feedlist into c323ffe on earthreader:master.

dahlia
dahlia reviewed Aug 2, 2013
View reviewed changes
libearth/feed.py
"""

if __name__ == '__main__':
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the block if __name__ == '__main__': is not necessary.

@dahlia
Copy link
Contributor

dahlia commented Aug 2, 2013

Plus, some critiques about coding style:

  • Please insert two blank lines between modue-level functions and classes.
  • Please list imports in alphabetical order (uppercase first). For example, from libearth.feed import Feed, AlreadyExistException should be from libearth.feed import AlreadyExistException, Feed.

@ghost ghost assigned tribela Aug 2, 2013
@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 6a7b062 on Kjwon15:feedlist into c323ffe on earthreader:master.

@dahlia
Copy link
Contributor

dahlia commented Aug 4, 2013

@Kjwon15 FYI http://dev.opml.org/spec2.html

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 077b023 on Kjwon15:feedlist into c323ffe on earthreader:master.

@dahlia
Copy link
Contributor

dahlia commented Aug 5, 2013

We use PascalCase for class names and names_with_underscores for variable, function and method names.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling eeae241 on Kjwon15:feedlist into c323ffe on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling a14513a on Kjwon15:feedlist into 8ce6392 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 189f214 on Kjwon15:feedlist into bbe2fb6 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 189f214 on Kjwon15:feedlist into bbe2fb6 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling ef4f001 on Kjwon15:feedlist into 863d584 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 2dded2a on Kjwon15:feedlist into 863d584 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 259b6b7 on Kjwon15:feedlist into 1e66280 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 8e5004b on Kjwon15:feedlist into 1e66280 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 3dbab4c on Kjwon15:feedlist into 1e66280 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 5dc07b1 on Kjwon15:feedlist into 9fbf6ce on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4b01085 on Kjwon15:feedlist into 9fbf6ce on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 6bb47a6 on Kjwon15:feedlist into 36d1ea1 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 19119cb on Kjwon15:feedlist into 36d1ea1 on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling a0c8b8c on Kjwon15:feedlist into 3de62da on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling f2980cd on Kjwon15:feedlist into 1e0e99e on earthreader:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.77%) when pulling f211761 on Kjwon15:feedlist into 1e0e99e on earthreader:master.

@dahlia
Copy link
Contributor

dahlia commented Aug 20, 2013

Treat acronyms as ordinary words in class names and function names e.g. OpmlDoc rather than OPMLDoc.

@tribela
add Boolean codec to codecs.py
15e3053
@tribela
add some special attributes to feed.py
50349ec
@tribela
change arguments of Boolean codec
51d3647
@tribela
change SaveOPMLError
230129a
@tribela
raise when Boolean.encoding or decoding
65aa8c6
@tribela
text_type -> string_type. add test codes
0e008d4
@tribela
code review
484bc6f
@tribela
fix circular referrence problem.
b4d9d34
@tribela
make FeedList.__contains__() to use as "feed in feedlist"
5cf0680
@tribela
change name OPMLXxx to OpmlXxx
843aa87
@tribela
remove unused attributes from FeedCategory
035d4e8
@tribela
start working on docstrings
c5d30e7
@tribela
start documentation codecs.py
8736d8d
@tribela
fix docstring
87071b1
@tribela
add docstring to Feed
29b87d8
@tribela
mv feed.py to feedlist.py
717198c
@tribela
add __all__ to feedlist.py
accd6b3
@tribela
Merge remote-tracking branch 'upstream/master' into feedlist
02c7253 
Conflicts:
	docs/libearth.rst
	libearth/codecs.py
	tests/codecs_test.py
@tribela
Merge remote-tracking branch 'upstream/master' into feedlist
ed55e3f
@tribela
replace 'Boolean', 'Enum' in alphabetical order
95e20b7
@tribela
add default value to FeedList
60754a9
@tribela
UTC to +0000. UTC is not valid RFC822 format
2a38389
@tribela
Merge remote-tracking branch 'upstream/master' into feedlist
3174408
@tribela
check timezone like "UTC"
a606408
@tribela
add tzinfo for valid rfc822
12d0e65
@coveralls
Copy link

Coverage Status

Coverage increased (+0.61%) when pulling 12d0e65 on Kjwon15:feedlist into 24e6869 on earthreader:master.

@dahlia dahlia merged commit 12d0e65 into earthreader:master Sep 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tribela tribela

Labels
enhancement
Projects
None yet
Milestone
Soma first half phase
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tribela @coveralls @dahlia