Check obj type using xml_url #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now crawler does not stop even if crawling a feed failed.
ghost
assigned 
| @@ -474,7 +474,7 @@ def make_feed(self, type, title, xml_url, html_url=None, text=None, | |||
| return feed | |||
|
|
|||
| def convert_from_outline(self, outline_obj): | |||
| if outline_obj.children: | |||
| if not outline_obj.xml_url: | |||
There was a problem hiding this comment.
If outline element has children(s) and doesn't have xmlUrl attribute, that is a FeedCategory, not a Feed.
So it shoud be
if outline_obj.children or not outline.xml_url:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now categories without children can be read rightly