Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid ImportError of urlparse #25

Merged
merged 1 commit into from
Dec 26, 2013
Merged

avoid ImportError of urlparse #25

merged 1 commit into from
Dec 26, 2013

Conversation

ychoi-kr
Copy link
Contributor

This change is for avoiding ImportError of urlparse on Python 3.

dahlia added a commit that referenced this pull request Dec 26, 2013
@dahlia
Merge pull request #25 from sk8erchoi/master
7da362d
dahlia added a commit that referenced this pull request Dec 26, 2013
@dahlia
Changelog and regression test for #25
58a338f
@dahlia dahlia merged commit 98a5cf2 into earthreader:master Dec 26, 2013
@dahlia
Copy link
Contributor

dahlia commented Dec 26, 2013

@sk8erchoi Thanks for your effort. It’s our fault that we hadn’t tested earthreader.web.command module and earthreader command, so I added a coarse-grained regression test for this as well.

@dahlia
Copy link
Contributor

dahlia commented Dec 26, 2013

This change will be included in 0.1.1 release; see also the changelog. Plus, please send pull request like this kind of bug fix to 0.1-maintenance branch rather than master branch. 😄 master is actually for the future major releases (e.g. 0.2), and 0.1-maintenace is for the next minor releases (e.g. 0.1.1). Thank you!

@ychoi-kr
Copy link
Contributor Author

Okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ychoi-kr @dahlia