Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello egyptian fruit bat datasets! #8

Closed
wants to merge 1 commit into from
Closed

hello egyptian fruit bat datasets! #8

wants to merge 1 commit into from

Conversation

oliver-adams-b
Copy link
Contributor

No description provided.

@bs bs closed this Sep 29, 2020
@bs
Copy link
Member

bs commented Sep 30, 2020

@oliver-adams-b, seems this pull request got auto-closed when we renamed the branch from master->main today. Apologies! Can you re-submit? See earthspecies/project#33.

@radekosmulski
Copy link
Contributor

I went through the PR and I it looks really great! I love the explanations with visualizations. For instance, the CQ transform (usage of parameters, the convention that frequency decreases on the y axis) is not intuitive at all - the visualizations really help. Same for the loss plots from training - they tell a really interesting story.

If you would be so kind and please resubmit against main, we'll go ahead and merge :)

Maybe as a follow up PR, could you please update the README.md of this repo to add a small note on this dataset?
image

I think the model is also in a good shape, would be great if you could add it to the table of available models.

If you'd rather me update the README.md, that is not a problem at all. Happy to go ahead and do it.

Again - thx so much for this outstanding contribution!

@oliver-adams-b
Copy link
Contributor Author

Hey! I was going to update the README during my initial pull, but I wouldn't have been able to include the correct links (since the links would have to point to my forked version of the library). I'll get to changing master->main !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants