Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "contentIsEmpty" query field for deleted documents #42

Open
3 of 5 tasks
cinnamon-bun opened this issue Aug 13, 2020 · 1 comment
Open
3 of 5 tasks

Add "contentIsEmpty" query field for deleted documents #42

cinnamon-bun opened this issue Aug 13, 2020 · 1 comment

Comments

@cinnamon-bun
Copy link
Member

cinnamon-bun commented Aug 13, 2020

What's the problem you want solved?

"Deleted documents" are docs with content: "".

We need to preserve them behind the scenes, as tombstones.

Sometimes we want them (when syncing), and sometimes not (when showing things in a UI).

Is there a solution you'd like to recommend?

@cinnamon-bun
Copy link
Member Author

cinnamon-bun commented Aug 13, 2020

Added in 34e9c75

    // If true, only match documents with content === "" (e.g. deleted documents)
    // If false, only match documents with content.length >= 1
    // If omitted, match all documents.
    contentIsEmpty?: boolean,

Tests pass with memory storage, but not all tests pass with sqlite storage. We're stuck waiting to figure out #44 to define what the right behavior should be.

@cinnamon-bun cinnamon-bun changed the title Add query field for deleted documents Add "contentIsEmpty" query field for deleted documents Aug 13, 2020
sgwilym pushed a commit that referenced this issue Feb 16, 2022
Add Peer, PeerClient and PeerServer classes
@sgwilym sgwilym removed this from the Acorn milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants