Stall on demand #19
Stall on demand #19
Conversation
|
please do performance tests yourself |
|
@easbar is there anything I can help you with? |
There was a problem hiding this comment.
I did not have a look at this because you said there was no speedup: #18 (comment)
Now I did some quick runs and it seems like there might be a 5-10% improvement, so still not sure if this is worth it tbh.
| let ranks_copy = self.fast_graph.ranks.clone(); | ||
| for i in 0..ranks_copy.len() { |
There was a problem hiding this comment.
Nice we do not have to do this. This is unrelated to stall on demand though, right? Can you open a separate PR for this to master? Otherwise I will just commit this straight to master.
There was a problem hiding this comment.
I commited it to master here: 192ae19
| @@ -173,7 +173,10 @@ impl PathCalculator { | |||
| let adj = graph.edges_bwd[edge_id].adj_node; | |||
| let edge_weight = graph.edges_bwd[edge_id].weight; | |||
| let adj_weight = self.get_weight_fwd(adj); | |||
| if adj_weight != WEIGHT_MAX && adj_weight + edge_weight < curr.weight { | |||
| if graph.ranks[adj] > graph.ranks[curr.node_id] | |||
There was a problem hiding this comment.
I still do not see why we need to check the ranks here. Do you have an example where no path is found without this check as you said here: #18 (comment)?
yes it runs fine, but I still do not see any speedup.
PS: this PR is not on to master