Add filter RedirectorV2 #1116
Merged
Add filter RedirectorV2 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
suchen-sci
approved these changes
Oct 31, 2023
|
It may be a little tricky. |
|
Sure I'm doing right that, will propose it in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's another feature left, which is ReplacePrefixMatch. Because there's no natural way to get the matching prefix in the router. So in the filter RedirectorV2 there's no way to get the real matching path prefix. It would be an intermediate change to httpserver/mux to do it. So let's hold it for the time being.