Support cookie hash #1132
Support cookie hash #1132
Conversation
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 7 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
pkg/filters/proxies/loadbalance.go
Outdated
| case LoadBalancePolicyCookieHash: | ||
| lbp = &HeaderHashLoadBalancePolicy{spec: &LoadBalanceSpec{HeaderHashKey: "Set-Cookie"}} |
There was a problem hiding this comment.
Set-Cookie is in response header that server send to client. In this place, client sends requests to server. I think maybe Cookie header is more appropriate.
As show in https://docs.oracle.com/en-us/iaas/Content/Balance/Reference/sessionpersistence.htm#cook__HowItWorks
The Load Balancer service calculates a hash of the configured cookie and other request parameters,
and sends that value to the client in a cookie.
The value stored in the cookie enables the service to route subsequent client requests to the correct backend server.
If your backend servers change any of the defined cookies,
the service recomputes the cookie's value and resends it to the client.
My understand for this is that load balancer use Set-Cookie header to set some information to client. And in later requests, get this information from Cookie header and use this information to route to correct server?
And for cookie hash, do we support to route based on a specific cookie or route based on all cookies? When use header.Get(), it is always return first cookie...
Fix #368