Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: add tzdata package for latest alpine #45

Merged
merged 2 commits into from Jun 21, 2021
Merged

Docker: add tzdata package for latest alpine #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa86c85
Docker: add tzdata package for latest alpine
Loyalsoldier Jun 18, 2021
9277c65
Chore: remove old files
Loyalsoldier Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/package/Dockerfile
View file
Open in desktop
Expand Up @@ -8,14 +8,14 @@ RUN make clean && make build

# ---

FROM alpine:3.13
FROM alpine:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest sounds cool, but can it guarantee stability?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release strategy of Alpine Linux seems promising: https://alpinelinux.org/releases/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest should be fine for now for our needs especially using a built golang executable. If we were using python or java on the other hand, beyond me running for the hills, we would have a much larger dependency on the libs provided by the base image


WORKDIR /opt/easegress

COPY build/package/entrypoint.sh /
COPY --from=builder /opt/easegress/bin/ /opt/easegress/bin/

RUN apk --no-cache add tini && \
RUN apk --no-cache add tini tzdata && \
chmod +x /entrypoint.sh /opt/easegress/bin/*

ENV PATH /opt/easegress/bin:$PATH
Expand Down
4 changes: 2 additions & 2 deletions build/package/Dockerfile.goreleaser
View file
Open in desktop
@@ -1,11 +1,11 @@
FROM alpine:3.13
FROM alpine:latest

WORKDIR /opt/easegress

ADD egctl easegress-server /opt/easegress/bin/
COPY build/package/entrypoint.sh /

RUN apk --no-cache add tini && \
RUN apk --no-cache add tini tzdata && \
chmod +x /entrypoint.sh /opt/easegress/bin/*

ENV PATH /opt/easegress/bin:$PATH
Expand Down