Upgrade MeshController to use TrafficController #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* informer reports service does not exist * informer generates empty notification
benja-wu
approved these changes
Jun 28, 2021
localvar
reviewed
Jun 29, 2021
Comment on lines
+92
to
+93
| mc.superSpec, mc.spec, mc.super = superSpec, superSpec.ObjectSpec().(*spec.Admin), super | ||
| mc.reload() |
There was a problem hiding this comment.
mc.api is not set as in function Init.
There was a problem hiding this comment.
@xxx7xxxx ， Is that necessary to introduce the api into MeshController? Since master and worker have handled the API registration inside. And I can't find any use of m.api in MeshController.
There was a problem hiding this comment.
It's expected. Otherwise it will cause repeating registering apis.
There was a problem hiding this comment.
if so, in Init, can we change
mc.api = api.New(superSpec, super)to
api.New(superSpec, super)and remove mc.api?
it is weird to only initialize the variable in Init.
There was a problem hiding this comment.
I don't see the difference. IMO, the standalone api.New is weirder to me. I updated it to api.Register
localvar
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.