Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in ReferenceQuadrangle_Method #280

Conversation

vickysharma0812
Copy link
Member

@vickysharma0812 vickysharma0812 commented Jan 30, 2024

  • Initiate method has been fixed

Generated summary (powered by Graphite)

TL;DR

This pull request modifies the ReferenceQuadrangle_Method@Methods.F90 file to fix an issue with the InterpolationPoint_Quadrangle function call. The xij parameter now correctly uses the entire refelem%xij array instead of a subset.

What changed

In the ReferenceQuadrangle_Method@Methods.F90 file, the InterpolationPoint_Quadrangle function call was modified. Previously, it was using a subset of the refelem%xij array (refelem%xij(1:3, 1:4)). Now, it uses the entire array (refelem%xij).

-    & xij=refelem%xij(1:3, 1:4), &
+    & xij=refelem%xij, &

How to test

To test this change, you can run the existing unit tests for the ReferenceQuadrangle_Method@Methods.F90 file. If the tests pass, it indicates that the change is working as expected. If there are no existing tests, consider adding some to verify the correct behavior of the InterpolationPoint_Quadrangle function call.

Why make this change

This change is necessary because the previous code was not using the entire refelem%xij array, which could lead to incorrect results. By using the entire array, we ensure that the InterpolationPoint_Quadrangle function has all the necessary data to perform its calculations correctly.

- Initiate method has been fixed
Copy link
Member Author

vickysharma0812 commented Jan 30, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@vickysharma0812 vickysharma0812 merged commit ecb49a6 into 01-26-Updating_BaseType Jan 30, 2024
2 checks passed
@vickysharma0812 vickysharma0812 deleted the 01-30-Fixing_bug_in_ReferenceQuadrangle_Method branch January 30, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant