Updates in ReferenceElement_Method #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vickysharma0812 and the rest of your teammates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pull request includes the addition of the 'GetElementIndex' method in the
Geometrymodule. This new method returns the index of an element based on its topology.What changed?
The changes can be noted in 'src/modules/Geometry/src/ReferenceElement_Method.F90' and 'src/submodules/Geometry/src/ReferenceElement_Method@GeometryMethods.F90'. A new function, 'GetElementIndex', has been added which returns the index of geometric elements like Point, Line, Triangle, Quadrangle, Tetrahedron, Hexahedron, Prism, and Pyramid based on their type.
How to test?
To validate these updates, build the project and validate that the new method correctly returns the expected indices when called with different geometric shapes.
Why make this change?
This change was needed as there was no method present earlier to retrieve the index of a geometric element based on its type. Hence, this new method 'GetElementIndex' would improve the functionality of the Geometry module.