fix: do not swallow exception on http client errors

easimon · Feb 4, 2024 · ef77464 · ef77464
1 parent 318e819
commit ef77464
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/src/main/kotlin/click/dobel/shelly/exporter/client/ShellyClient.kt b/src/main/kotlin/click/dobel/shelly/exporter/client/ShellyClient.kt
@@ -24,7 +24,7 @@ abstract class ShellyClient(
         restTemplate.getForObject<T>(url)
       }
     }.getOrElse { ex ->
-      logger.warn { "GET ${url}: HTTP Request failure: ${ex.message}" }
+      logger.warn(ex) { "GET ${url}: HTTP Request failure: ${ex.message}" }
       null
     }
   }

diff --git a/src/main/kotlin/click/dobel/shelly/exporter/client/ShellyGen2Client.kt b/src/main/kotlin/click/dobel/shelly/exporter/client/ShellyGen2Client.kt
@@ -15,7 +15,6 @@ class ShellyGen2Client(
   configProperties: ShellyConfigProperties,
   restTemplateBuilder: RestTemplateBuilder
 ) : ShellyClient(this) {
-
   companion object : KLogging()
 
   @Cacheable("Gen2ShellyStatus", sync = true)

diff --git a/src/main/kotlin/click/dobel/shelly/exporter/client/api/gen2/Gen2ShellyStatus.kt b/src/main/kotlin/click/dobel/shelly/exporter/client/api/gen2/Gen2ShellyStatus.kt
@@ -3,6 +3,7 @@ package click.dobel.shelly.exporter.client.api.gen2
 import com.fasterxml.jackson.annotation.JsonProperty
 import java.util.EnumSet
 
+@Suppress("LongParameterList")
 class Gen2ShellyStatus(
   //@JsonProperty("ble")