Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD compatibility patch #37

Closed
GoogleCodeExporter opened this issue Dec 7, 2015 · 3 comments
Closed

OpenBSD compatibility patch #37

GoogleCodeExporter opened this issue Dec 7, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Sorry for creating a new issue but that's the only way to attach a file
here. Skipfish compiles cleanly, not much tested in production.

Original issue reported on code.google.com by pawel.kr...@hush.com on 25 Mar 2010 at 11:18

Attachments:

@GoogleCodeExporter
Copy link
Author

This will not work as expected:

#define ck_realloc      realloc

...since the whole point of ck_realloc() - and the only reason there is a 
dependency
on malloc_size() / malloc_usable_size() - is that the newly added space is 
always
memset to 0; realloc() does not bear this guarantee.

Also:

+       new = calloc(1, size);
+       memcpy(new, mem, size);

#define ck_strdup       strdup

Unlike the original wrappers, this does not seem to be doing any return value
checking, and will crash on OOM.

Original comment by lcam...@google.com on 25 Mar 2010 at 5:35

@GoogleCodeExporter
Copy link
Author

Original comment by lcam...@gmail.com on 25 Mar 2010 at 5:36

  • Added labels: Priority-Low, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect

@GoogleCodeExporter
Copy link
Author

Merging bugs.

Original comment by lcam...@gmail.com on 26 Mar 2010 at 6:33

  • Changed state: Duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant