Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition #10

Closed
djmango opened this issue Jan 27, 2024 · 7 comments
Closed

Race condition #10

djmango opened this issue Jan 27, 2024 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@djmango
Copy link

djmango commented Jan 27, 2024

image

Just gonna submit a PR for this real quick adding a conditional

djmango added a commit to djmango/LLM.swift that referenced this issue Jan 27, 2024
Race condition? history was not set perhaps

Closes eastriverlee#10
@djmango
Copy link
Author

djmango commented Jan 27, 2024

image I think its a race condition

@djmango
Copy link
Author

djmango commented Jan 27, 2024

Or maybe sending in an empty array + content causes this? going to just stop sending empty arrays lol but something to consider

@eastriverlee
Copy link
Owner

okay i should consider switching main logic to actor. thank you for reporting.

@eastriverlee eastriverlee changed the title History removal check items Race condition Jan 27, 2024
@eastriverlee eastriverlee self-assigned this Jan 27, 2024
@eastriverlee eastriverlee added bug Something isn't working good first issue Good for newcomers labels Jan 27, 2024
@djmango
Copy link
Author

djmango commented Jan 27, 2024

    ###Instructions###

    Provide exactly two words for a title for the above chat. YOU WILL BE PENALIZED for any additional words, print exactly two words

For some reason this prompt causes a crash - this is the cause of the Int32 crash i posted above

@eastriverlee
Copy link
Owner

if you give me the model, the seed, and the template you've used, it will be easier for me to check later. can you provide me those details?

@eastriverlee
Copy link
Owner

give me any minimal reproducible case if you can please.

@djmango
Copy link
Author

djmango commented Jan 27, 2024

Running mistral-7b-instruct-v0.2.Q4_K_M.gguf - not sure about seed, how could that be determined? It replicates every time running that string on .respond (using the .mistral template)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants