Skip to content

Commit

Permalink
fix go extension test annotation (envoyproxy#26887)
Browse files Browse the repository at this point in the history
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
  • Loading branch information
StarryVae committed Apr 25, 2023
1 parent 465a1fd commit ea9b479
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions contrib/golang/filters/http/test/golang_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,12 @@ name: golang
EXPECT_EQ(true,
upstream_request_->headers().get(Http::LowerCaseString("x-test-header-1")).empty());

// check header value which set in golang: req-downstream-local-address
EXPECT_TRUE(
absl::StrContains(getHeader(upstream_request_->headers(), "req-downstream-local-address"),
GetParam() == Network::Address::IpVersion::v4 ? "127.0.0.1:" : "[::1]:"));

// check header value which set in golang: req-downstream-remote-address
EXPECT_TRUE(
absl::StrContains(getHeader(upstream_request_->headers(), "req-downstream-remote-address"),
GetParam() == Network::Address::IpVersion::v4 ? "127.0.0.1:" : "[::1]:"));
Expand Down Expand Up @@ -310,7 +312,7 @@ name: golang
// check route name in encode phase
EXPECT_EQ("test-route-name", getHeader(response->headers(), "rsp-route-name"));

// check route name in encode phase
// check protocol in encode phase
EXPECT_EQ("HTTP/1.1", getHeader(response->headers(), "rsp-protocol"));

// check filter chain name in encode phase, exists.
Expand All @@ -323,7 +325,7 @@ name: golang
// check response code details in encode phase
EXPECT_EQ("via_upstream", getHeader(response->headers(), "rsp-response-code-details"));

// check response code details in encode phase
// check response attempt count in encode phase
EXPECT_EQ("1", getHeader(response->headers(), "rsp-attempt-count"));

// verify response status
Expand Down

0 comments on commit ea9b479

Please sign in to comment.