Locator grid #11
Merged
Locator grid #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a renderer update to ensure all images are appropriately sized and centered.
…iate image boundaries.
… likely an issue to begin with.
jacksonj04
requested changes
Mar 5, 2019
It does. It's actually an issue with the scaling update not correctly altering image offsets which was previously hidden under the now impossible pixel offset in the locator class. Should now be resolved. |
jacksonj04
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alters locator grid to do location offsets in terms of grid location, not pixel (so the same image_location_list can be passed to renderer in multiple offsets on the grid.
In order to make sure images still render nicely, also moves the responsibility for getting the width and height of the final image (and positioning all sub_images correctly within that frame) to the Renderer.