Build fails if your node binary isn't called nodejs

[jonaslund]

Easily fixed by changing this line in binding.gyp
"include_dirs": [ "./external/matrix/include", "./include/", "<!(nodejs -e \"require('nan')\")" ]

Should be fixed

[keptan]

thanks ill look into this

[redandinvisible]

I am having the same problem. Is there a workaround by any chance?

[redandinvisible]

In case it helps others:

I cloned this repo and made it a local dependency. Then I changed the line in the local binding.gyp so the node binary was just called node. Tried npm install again which gave a new error make: *** No rule to make target `Release/obj.target/rpi-rgb-led-matrix/external/matrix/lib/transformer.o', needed by `Release/rpi-rgb-led-matrix.a'..

Turns out this was caused by some clever cross-github linking in the external directory to this "rpi-rgb-led-matrix" github repo. So I cloned the contents of that repo into the external directory. Removed the uneeded .git directories. And it now builds.

[samturner3]

+1

[keptan]

@redandinvisible the second half of your issue is just a matter of checking out submodules, I should make that clearer in the readme probably
when you pull from npm this isn't an issue

still haven't changed the binding.gyp sorry

[keptan]

e4bae0b

finally dealing with this