get rid of hardcoding BLAS libs in easyblocks #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in.get_variable where appropriate
…CK_MT').split(' -l') for now
…las_opt]/[lapack_opt]
| lapack_libs.try_function_by_elem('change', prefix='', prefix_begin_end='-Wl:', | ||
| separator=',', separator_begin_end=',') | ||
| lapack_libs.SEPARATOR = ',' | ||
| lapack = str(lapack_libs) |
There was a problem hiding this comment.
@boegel isn't this also needed for the fftw configuration? (i saw the easybuildlog of earlier builds that it isn't, dunno if it matters or not)
There was a problem hiding this comment.
Hmm, good point.
I think it is needed, and that we've been building numpy without FFT support with ictce up until now... I'll look into it, good catch.
|
@stdweird: Fixed remark, please rerereview. |
|
might just work, regtests will tell ;) |
|
Fully tested, Python+numpy_scipy builds as expected with goolf and ictce using this. Merging it in. |
boegel
added a commit
that referenced
this pull request
Mar 28, 2013
get rid of hardcoding BLAS libs in easyblocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.