make sure ~/.cache/pip isn't used while installing Tkinter #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
reviewed
Apr 23, 2019
| shutil.move(os.path.join(tmpdir, os.path.basename(tkparts[1])), pylibdir) | ||
| except (IOError, OSError) as err: | ||
| raise EasyBuildError("Failed to move Tkinter back to the install directory: %s", err) | ||
| move_file(os.path.join(tmpdir, tkparts[0]), os.path.join(pylibdir, tkparts[0])) |
There was a problem hiding this comment.
Can't move_file take a dir as the second arg? Because if it can you should only need pylibdir there and not the path.join with tkparts[0].
And the same for the one below.
There was a problem hiding this comment.
Right now, it can't.
The problem is that you can't distinguish between a file or directory if the target doesn't exist yet in case you're moving a file: should the target directory be created, and the file moved into it, or should the parent of the target be created as a directory, and then the file moved to the specified target?
There was a problem hiding this comment.
Aha, forgot the non-exist dir situation...
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deliberately broke the use of
$HOME/.cache/pipin my test account to catch occurrences wherepiptries to use it (after we told it not to in #1687.Tkinterinstalled failed because of that, with aPermission deniedon$HOME/.cache/pip/wheels:which can be circumvented by pointing
$XDG_CACHE_HOMEto a temporary location