add support for building CBLAS and fix numpy easyblock to get an optimal build (w.r.t. numpy.dot performance) #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent name in a Python 3.x environment, nd iand it's checked already by the import test
| for solib in glob.glob(os.path.join(srcdir, 'libcblas.so*')): | ||
| shutil.copy2(solib, targetdir) | ||
| except OSError, err: | ||
| self.log.error("Failed to install CBLAS: %s" % err) |
There was a problem hiding this comment.
the err message is not useful. at least add src and target dir (and move the assignmnet out of the try block)
boegel
added a commit
that referenced
this pull request
May 21, 2013
add support for building CBLAS and fix numpy easyblock to get an optimal build (w.r.t. numpy.dot performance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.