Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom easyblock for code-server #2255

Merged
merged 5 commits into from Dec 7, 2020
Merged

add custom easyblock for code-server #2255

merged 5 commits into from Dec 7, 2020

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Nov 27, 2020

No description provided.

@ocaisa ocaisa mentioned this pull request Nov 27, 2020
Merged
@boegel boegel changed the title Add support for code-server add custom easyblock for code-server Dec 1, 2020
@boegel boegel added the new label Dec 1, 2020
@boegel boegel added this to the 4.x milestone Dec 1, 2020
boegel
boegel previously requested changes Dec 1, 2020
View reviewed changes
easybuild/easyblocks/c/code_server.py Show resolved Hide resolved
@Micket
Copy link
Contributor

Micket commented Dec 7, 2020

Hm, what's up with easybuild/easyblocks/c/chimera.py the empty file?

@ocaisa
Copy link
Member Author

ocaisa commented Dec 7, 2020

When I was in that dir I noticed it had execute permissions, so I removed them

Micket
Micket approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket dismissed boegel’s stale review December 7, 2020 22:23

all seems fixed now

@Micket Micket merged commit de4c3ee into easybuilders:develop Dec 7, 2020
@boegel boegel modified the milestones: 4.x, 4.3.2 (next release) Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

@boegel boegel boegel left review comments

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocaisa @Micket @boegel