Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip extension download pattern for PythonPackage easyblock #2372

Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Mar 29, 2021

(created using eb --new-pr)

I suspect that this has changed for more recent versions of pip

I discovered this when setting use_pip_for_deps = True, which could be handy for automatically detecting missing dependencies. pip_sanity_check does not always work for that because it does not report missing dependencies of dependencies.

example pip output:

 Collecting geographiclib<2,>=1.49
  Downloading geographiclib-1.50-py3-none-any.whl (38 kB)

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@boegel boegel added the bug fix label Mar 31, 2021
@boegel boegel modified the milestones: 4.x, next release (4.3.4?) Mar 31, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 25a1423 into easybuilders:develop Mar 31, 2021
@boegel boegel changed the title fix pip extension download pattern for pythonpackage easyblock fix pip extension download pattern for PythonPackage easyblock Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants