Updated numpy easyblock to use read_file for patch. #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
reviewed
Apr 26, 2021
| @@ -142,7 +142,7 @@ def get_libs_for_mkl(varname): | |||
| # patches are either strings (extension) or dicts (easyblock) | |||
| if isinstance(patch, dict): | |||
| patch = patch['path'] | |||
| if patch_wl_regex.search(open(patch, 'r').read()): | |||
| if patch_wl_regex.search(read_file(patch)): | |||
There was a problem hiding this comment.
(sorry that was a stupid comment)
There was a problem hiding this comment.
@dithwick can you create a test report that includes this PR?
|
Test report by @dithwick Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Going in, thanks @dithwick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2393 (for numpy.py only).