Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename build_targets to build_cmd_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks #2479

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jun 17, 2021

(created using eb --new-pr)

Alternative to #2478.

#2449 added the functionality to build for multiple targets. This means that the items in build_targets are looped over and run as separate builds. However, the LLVM and Clang easyblocks use build_targets to set the machine types to build for in the CMake configure step. Without it we see make X86 -j 12 when building and that leads to the error make: *** No rule to make target 'X86'. Stop.

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-11.1.0-GCCcore-10.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0206u05a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/1d8ab8da65acc502c7a6abe53b887886 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-11.1.0-GCCcore-10.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrlogin11.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor, Python 3.6.8
See https://gist.github.com/03894c45296a98660c99052fea07420b for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-11.1.0-GCCcore-10.3.0.eb
  • SUCCESS LLVM-11.0.0-GCCcore-10.2.0.eb
  • SUCCESS LLVM-10.0.1-GCCcore-10.2.0.eb
  • SUCCESS LLVM-9.0.1-GCCcore-9.3.0.eb
  • SUCCESS Clang-11.0.1-GCCcore-10.2.0.eb
  • SUCCESS Clang-11.0.0-GCCcore-9.3.0.eb
  • SUCCESS Clang-10.0.1-GCCcore-9.3.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/71f7a3b3df2214c3561682200a4a6007 for a full test report.

@boegel boegel changed the title rename build_targets as this clashes with the use in the Clang and LLVM easyblocks rename build_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks Jun 18, 2021
@boegel
Copy link
Member

boegel commented Jun 18, 2021

@branfosj This needs a merge conflict fix after #2480

@boegel
Copy link
Member

boegel commented Jun 18, 2021

cc'ing @mboisson since he issued #2449

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title rename build_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks rename build_targets to build_cmd_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks Jun 18, 2021
@boegel
Copy link
Member

boegel commented Jun 18, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PRINSEQ-0.20.4-foss-2018b-Perl-5.28.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a52c44fc58252817149f94366eb95e27 for a full test report.

@boegel boegel enabled auto-merge June 18, 2021 14:58
@boegel boegel merged commit 57cf5c8 into easybuilders:develop Jun 18, 2021
@branfosj branfosj deleted the 20210617223100_new_pr_sIfcNMulJK branch June 18, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants