New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename build_targets to build_cmd_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks #2479
rename build_targets to build_cmd_targets in ConfigureMake as this clashes with the use in the Clang and LLVM easyblocks #2479
Conversation
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (7 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
(created using
eb --new-pr
)Alternative to #2478.
#2449 added the functionality to build for multiple targets. This means that the items in
build_targets
are looped over and run as separate builds. However, the LLVM and Clang easyblocks usebuild_targets
to set the machine types to build for in the CMake configure step. Without it we seemake X86 -j 12
when building and that leads to the errormake: *** No rule to make target 'X86'. Stop.