Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable build-in-installdir mode in constructor of PETSc and SLEPc easyblocks #2631

Merged
merged 1 commit into from
Dec 7, 2021
Merged

enable build-in-installdir mode in constructor of PETSc and SLEPc easyblocks #2631

merged 1 commit into from
Dec 7, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 7, 2021

(created using eb --new-pr)
This is important in the context of the fix made in easybuilders/easybuild-framework#3900, to ensure that self.builddir is set correctly in these easyblocks

@boegel boegel added the bug fix label Dec 7, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Dec 7, 2021
@boegel boegel requested a review from branfosj December 7, 2021 19:23
@boegel boegel changed the title enable build-in-installdir mode in constructor of PETSc and SLEPc easyblocks (cfr. https://github.com/easybuilders/easybuild-framework/pull/3900) enable build-in-installdir mode in constructor of PETSc and SLEPc easyblocks Dec 7, 2021
branfosj
branfosj approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

branfosj commented Dec 7, 2021

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS SLEPc-3.12.2-foss-2020a-Python-3.8.2.eb
  • SUCCESS MUMPS-5.4.0-foss-2021a-metis.eb
  • SUCCESS SCOTCH-6.1.0-iimpi-2020b.eb
  • SUCCESS Hypre-2.21.0-foss-2021a.eb
  • SUCCESS MUMPS-5.3.5-intel-2020b-metis.eb
  • SUCCESS PETSc-3.15.1-foss-2021a.eb
  • SUCCESS SLEPc-3.15.1-foss-2021a.eb
  • SUCCESS SuiteSparse-5.8.1-intel-2020b-METIS-5.1.0.eb
  • SUCCESS Hypre-2.20.0-intel-2020b.eb
  • SUCCESS PETSc-3.14.4-intel-2020b.eb

Build succeeded for 10 out of 10 (4 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/aa529bfc46ee64a10fd4252a1164d08e for a full test report.

@branfosj
Copy link
Member

branfosj commented Dec 7, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit c4e890a into easybuilders:develop Dec 7, 2021
@boegel boegel deleted the 20211207202136_new_pr_petsc branch December 7, 2021 22:21
@boegel
Copy link
Member Author

boegel commented Dec 7, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS PETSc-3.12.4-foss-2020a-Python-3.8.2.eb
  • SUCCESS PETSc-3.14.4-intel-2020b.eb
  • SUCCESS SLEPc-3.12.2-foss-2020a-Python-3.8.2.eb
  • SUCCESS SLEPc-3.15.1-foss-2021a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2613.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/de99d4f50bab864984e07378fa070ccd for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branfosj branfosj branfosj approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @branfosj