Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in MPICH easyblock optional #2787

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in MPICH easyblock optional #2787

wants to merge 3 commits into from

Conversation

damianam
Copy link
Member

and to make the check for static libs in mpich optional, as they aren't always there

@damianam
To enable the psmpi easyblock to activate CUDA when it is a dependency,
d5bde64 
and to make the check for static libs in mpich optional, as they aren't
always there
@damianam
Style
f5d7c9b
@damianam
Deambiguate variable name
ecbe191
ocaisa
ocaisa approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Any chance we can get a test report?

@boegel boegel changed the title To enable the psmpi easyblock to activate CUDA when it is a dependency, enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in mpich optional Oct 12, 2022
@boegel boegel changed the title enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in mpich optional enhance psmpi easyblock to activate CUDA support when it is a dependency + make check for static libs in MPICH easyblock optional Oct 12, 2022
@boegel boegel added this to the 4.x milestone Oct 12, 2022
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS psmpi-5.8.0-1-GCC-11.3.0.eb
  • SUCCESS MPICH-3.4.2-GCC-10.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bwd-rockylinux-92 - Linux Rocky Linux 9.2 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.9.16
See https://gist.github.com/SebastianAchilles/35c2ec66a9cbab42ea37a7b301aff95d for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damianam @SebastianAchilles @ocaisa @boegel