enhance Rosetta easyblock to build with serialization support #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikerr
commented
Dec 8, 2022
alikerr
commented
- Fix for database in the version 3.13.
- Adding the option to compile with mpi,seriallization using a flag in the easyconfig: serialization=True or False
- Fix for database in the version 3.13. - Adding the option to compile with mpi,seriallization using a flag in the easyconfig: serialization=True or False
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| cpaths = cpaths.split(':') if cpaths else [] | ||
| paths = os.getenv('PATH').split(':') | ||
| #ld_library_paths = os.getenv('LD_LIBRARY_PATH').split(':') | ||
| cpaths = os.getenv('CPATH').split(':') |
There was a problem hiding this comment.
local variable 'cpaths' is assigned to but never used
| cpaths = os.getenv('CPATH') | ||
| cpaths = cpaths.split(':') if cpaths else [] | ||
| paths = os.getenv('PATH').split(':') | ||
| #ld_library_paths = os.getenv('LD_LIBRARY_PATH').split(':') |
There was a problem hiding this comment.
This one was fixed in the previous PR #2744
branfosj
requested changes
Dec 10, 2022
easybuild/easyblocks/r/rosetta.py
Outdated
Comment on lines
252
to
253
| else: | ||
| extract_and_copy('rosetta_database%s') |
There was a problem hiding this comment.
I expect this is needed for older versions. If this is no longer useful for 3.13, then we should change this to a version check, so:
elif LooseVersion(self.version) < LooseVersion("3.13"):
extract_and_copy('rosetta_database%s')
There was a problem hiding this comment.
I think I uploaded a wrong version of the file. I have just updated the right file on my git repo 73dc29d
boegel
requested changes
Dec 21, 2022
| " 'ENV': {", | ||
| " 'INTEL_LICENSE_FILE': '%s'," % os.getenv('INTEL_LICENSE_FILE'), # Intel license file | ||
| " 'PATH': %s," % str(paths), | ||
| " 'LD_LIBRARY_PATH': %s," % str(ld_library_paths), |
There was a problem hiding this comment.
@alikerr These look like unintended changes to the exiting easyblock?
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.