update ESMF easyblock for versions >= 8.4, due to changed structure and naming of their Python bindings #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
smoors
reviewed
Feb 28, 2023
| run_cmd(cmd, log_all=True, simple=True, log_ok=True) | ||
| else: | ||
| cmd = "ESMFMKFILE=%s/lib/esmf.mk " % self.installdir | ||
| cmd += "python -m pip install . --no-deps --prefix=%s" % self.installdir |
There was a problem hiding this comment.
EB also adds pip options --ignore-installed --no-index --no-build-isolation, shouldn't those be added here too?
There was a problem hiding this comment.
I agree with @smoors that we should add those additional options for pip install, they're there for a reason (and it's better to err on the side of caution with installing Python packages).
It would be nicer if we could query PythonPackage for which options to pass to pip install though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.