Update IPP easyblock for versions > 2021 #2909
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
boegel
changed the title
|
Test report by @akesandgren Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
As you can see, this breaks installation of older ipp versions. |
Mhm, thats interesting. The error is "directory already exists", but my patch actually introduces the suppression of making the installdir, because I thought it was newer installers that had problems with this. Does the 2017 version actually work before the patch? |
|
Yes it works before this PR. See my fix for the problem above. |
Sorry, where exactly? |
| def make_installdir(self): | ||
| """Do not create installation directory, install script handles that already.""" | ||
| if LooseVersion(self.version) >= LooseVersion('2021'): | ||
| super(EB_ipp, self).make_installdir(dontcreate=True) |
There was a problem hiding this comment.
This is wrong, you need an else-stmt which calls
super(EB_ipp, self).make_installdir()
Or add a variable "dontcreate=None", changing it to True if version > 2021 and then call supr(...).make_installdir(dontcreate=dontcreate)
The latter depends a bit too much of a-prio knowledge of what the default for dontcreate is in the super classes.
So the first way is less prone to get hit by a change in intelbase.py or frameworks easyblock.py
There was a problem hiding this comment.
With that change installing ipp-2017.1.132.eb works again.
|
Sorry, I managed to forget to click send the review. |
|
@agemuend ping |
(created using
eb --new-pr)