Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable system pybind11 for PyTorch 1.10+ to make sure pybind11 provided as dependency is used #2968

Merged
merged 1 commit into from Aug 1, 2023
Merged

enable system pybind11 for PyTorch 1.10+ to make sure pybind11 provided as dependency is used #2968

merged 1 commit into from Aug 1, 2023

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 31, 2023 •
edited

(created using eb --new-pr)

PyTorch switched to custom pybind11 by default in 1.10: pytorch/pytorch@7179e7e

But we provide our Pybind11, which was used before and IMO should still be used.

@Flamefire Flamefire marked this pull request as draft July 31, 2023 07:16
@Flamefire Flamefire changed the title Enable system Pybin11 for PyTorch 1.10+ Enable system Pybind11 for PyTorch 1.10+ Jul 31, 2023
@migueldiascosta
Copy link
Member

sounds good to me

@Flamefire
Copy link
Contributor Author

I'm currently running some builds to verify this doesn't break anything. Will mark this as ready once they succeeded.

@Flamefire Flamefire force-pushed the 20230731091354_new_pr_pytorch branch from 3e39d2d to cfeb5a1 Compare July 31, 2023 09:05
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS PyTorch-1.10.0-foss-2021a.eb
  • SUCCESS PyTorch-1.12.1-foss-2021a.eb
  • SUCCESS PyTorch-1.12.1-foss-2021b.eb
  • SUCCESS PyTorch-1.12.1-foss-2022a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
taurusi8022 - Linux CentOS Linux 7.9.2009, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 470.57.02, Python 2.7.5
See https://gist.github.com/Flamefire/6004c092ef23c0c27b73f105094c822d for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS PyTorch-1.10.0-foss-2021a.eb
  • SUCCESS PyTorch-1.12.1-foss-2021a.eb
  • SUCCESS PyTorch-1.12.1-foss-2021b.eb
  • SUCCESS PyTorch-1.12.1-foss-2022a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
taurusml5 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/Flamefire/13c515ec243ffcf987975e56b832d054 for a full test report.

@Flamefire Flamefire marked this pull request as ready for review August 1, 2023 07:37
@Flamefire
Copy link
Contributor Author

I tested 4 ECs with and without this PR on 2 architectures. Seems to work just fine, so I'd say this is good to go!

@Flamefire Flamefire mentioned this pull request Aug 1, 2023
Merged
migueldiascosta
migueldiascosta approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta added this to the next release (4.8.1?) milestone Aug 1, 2023
@migueldiascosta
Copy link
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit 2ecd3c9 into easybuilders:develop Aug 1, 2023
47 checks passed
@Flamefire Flamefire deleted the 20230731091354_new_pr_pytorch branch August 1, 2023 08:25
@boegel boegel changed the title Enable system Pybind11 for PyTorch 1.10+ enable system pybind11 for PyTorch 1.10+ to make sure pybind11 provided as dependency is used Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flamefire @migueldiascosta