Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor GAMESS-US easyblock to directly write install.info (v2) #3047

Merged
merged 42 commits into from May 10, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Dec 6, 2023

Follow-up of #2791

Main changes:

  • remove QA, instead configure installation by directly writing the install.info file
  • update configuration options and supported dependencies from version 2020xxxx to 2023xxxx
  • run all tests for non-MPI builds in serial
  • run tests for MPI builds in parallel with the same parallelization of the install and exclude those tests known to only work in serial

Fixes easybuilders/easybuild-easyconfigs#19791 (commit 1bfd253)

sassy and others added 26 commits September 22, 2022 14:23
@lexming lexming changed the title update GAMESS-US easyblock to directly write install.info (v2) refactor GAMESS-US easyblock to directly write install.info (v2) Dec 18, 2023
@boegel boegel added this to the 4.x milestone Dec 20, 2023
@lexming

This comment was marked as outdated.

boegel
boegel previously requested changes Jan 31, 2024
easybuild/easyblocks/g/gamess_us.py Outdated Show resolved Hide resolved
@lexming
Copy link
Contributor Author

lexming commented Feb 3, 2024

Following the discussion in our last conf call I updated the code executing the tests to run all tests in serial for non-MPI builds of GAMESS-US. No further changes for the tests of MPI builds, those must be run in parallel (rungms does not allow to run in a single core in mpi mode) and we filter out those tests known to not be compatible with a parallel run.

@lexming
Copy link
Contributor Author

lexming commented Feb 3, 2024

Tests Reports

I made 2 configurations complementing each other to cover as many options as possible with the least amount of tests:

  1. MPI build with foss stack
  2. Non-MPI build with intel stack

v20230930-R2

v20220930-R2

@lexming
Copy link
Contributor Author

lexming commented May 8, 2024

Latest test reports

v20230930-R2

v20220930-R2

@branfosj branfosj modified the milestones: 4.x, release after 4.9.1 May 10, 2024
@branfosj
Copy link
Member

Going in, thanks @lexming!

@branfosj branfosj merged commit 7b845dd into easybuilders:develop May 10, 2024
47 checks passed
@lexming lexming deleted the gamess-2023 branch May 10, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential issue with MKL spotted in GAMESS-US builds
3 participants