Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename run method to install_extension, and likewise for prerun to pre_install_extension, postrun to post_install_extension, and run_async to install_extension_async #3064

Merged
merged 3 commits into from Mar 11, 2024
Merged

rename run method to install_extension, and likewise for prerun to pre_install_extension, postrun to post_install_extension, and run_async to install_extension_async #3064

merged 3 commits into from Mar 11, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 3, 2024

@boegel
rename 'run' method to 'install_extension', and likewise for 'prerun'…
adafb79 
… to 'pre_install_extension', 'postrun' to 'post_install_extension', and 'run_async' to 'install_extension_async'
@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Jan 3, 2024
@boegel boegel added this to the 5.0 milestone Jan 3, 2024
@boegel boegel mentioned this pull request Jan 3, 2024
Merged
@boegel boegel requested a review from lexming January 29, 2024 14:06
lexming
lexming approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming merged commit e2c3d37 into easybuilders:5.0.x Mar 11, 2024
17 checks passed
@boegel boegel deleted the install_extension branch March 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @lexming