New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use (=|:=)
in regex because OpenFOAM rule files use :=
instead of =
since v2212
#3073
use (=|:=)
in regex because OpenFOAM rule files use :=
instead of =
since v2212
#3073
Conversation
(=|:=)
in regex because OpenFOAM rule files use :=
instead of =
since v2212
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after visual review
@mboisson Can you clarify in the PR description how problems manifest if OpenFOAM v2212 was installed without this fix (which errors, etc.)? |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1896067033 processed Message to humans: this is just bookkeeping information for me, |
The way it manifested for us is that A way to detect that would probably to test whether the regex actually applied something. In our case, for example, not fixed (avx2)
(returns nothing), vs fixed (avx512):
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.