Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hidden=True from run_shell_cmd in PythonPackage easyblock for consistency #3074

Merged

Conversation

bartoldeman
Copy link
Contributor

To address
#3046 (comment) as a followup to #3046

@bartoldeman bartoldeman added this to the 5.0 milestone Jan 15, 2024
@boegel boegel changed the title pythonpackage: Remove hidden=True from run_shell_cmd for consistency remove hidden=True from run_shell_cmd in PythonPackage easyblock for consistency Jan 15, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

  • SUCCESS Pillow-10.0.0-GCCcore-12.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jscclxc1.int.jsc-clx.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, Intel Xeon Processor (Cascadelake) (cascadelake), Python 3.9.18
See https://gist.github.com/SebastianAchilles/e4ac5b0f471cd730311c97169efc333e for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @bartoldeman!

@SebastianAchilles SebastianAchilles merged commit 4e63956 into easybuilders:5.0.x Jan 15, 2024
29 checks passed
@boegel
Copy link
Member

boegel commented Jan 15, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS matplotlib-3.7.2-gfbf-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4005.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), 1 x NVIDIA NVIDIA A2, 535.129.03, Python 3.6.8
See https://gist.github.com/boegel/16d9de2b9ae5d1de93a5c03577f79e01 for a full test report.

@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants