Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Clang opt binary to RPATH wrapper dir #3076

Merged
merged 2 commits into from Jan 17, 2024
Merged

add Clang opt binary to RPATH wrapper dir #3076

merged 2 commits into from Jan 17, 2024

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Jan 15, 2024 •
edited

addresses #3075

(created using eb --new-pr)

@jfgrimm jfgrimm added this to the 4.x milestone Jan 15, 2024
@jfgrimm jfgrimm linked an issue Jan 15, 2024 that may be closed by this pull request
Clang builds fail due to not finding opt when using rpath #3075
Closed
@jfgrimm

This comment was marked as resolved.

Sign in to view
@jfgrimm
Copy link
Member Author

jfgrimm commented Jan 16, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-13.0.1-GCCcore-11.3.0-CUDA-11.7.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node033.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/85b6a44db0e6fd355cc01c16eb74ca2e for a full test report.

@jfgrimm
Copy link
Member Author

jfgrimm commented Jan 16, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • FAIL (build issue) Clang-10.0.0-GCCcore-8.3.0.eb (partial log available at https://gist.github.com/jfgrimm/11e5e9caafafe6ef09d830c794d45941)
  • SUCCESS Clang-11.0.1-GCCcore-10.2.0.eb
  • SUCCESS Clang-12.0.1-GCCcore-10.3.0.eb
  • SUCCESS Clang-13.0.1-GCCcore-11.2.0.eb
  • SUCCESS Clang-13.0.1-GCCcore-11.3.0.eb
  • SUCCESS Clang-15.0.5-GCCcore-11.3.0.eb
  • SUCCESS Clang-16.0.6-GCCcore-12.3.0.eb
  • SUCCESS Z3-4.8.9-GCCcore-9.3.0.eb
  • SUCCESS Z3-4.12.2-GCCcore-12.2.0.eb
  • SUCCESS Clang-11.0.0-GCCcore-9.3.0.eb
  • SUCCESS Clang-16.0.4-GCCcore-12.2.0.eb

Build succeeded for 10 out of 11 (9 easyconfigs in total)
himem01.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/133993586e3a38ea8fcfd0a4921e3dee for a full test report.

@boegel boegel changed the title add clang 'opt' binary to rpath wrapper dir add clang opt binary to RPATH wrapper dir Jan 17, 2024
@boegel boegel modified the milestones: 4.x, release after 4.9.0 Jan 17, 2024
@boegel boegel changed the title add clang opt binary to RPATH wrapper dir add Clang opt binary to RPATH wrapper dir Jan 17, 2024
boegel
boegel approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 17, 2024

GCCcore/8.3.0 toolchain is no longer supported, so not blocking this PR over that one test failure...

@boegel boegel merged commit 911fc16 into easybuilders:develop Jan 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

Clang builds fail due to not finding opt when using rpath
2 participants
@jfgrimm @boegel