Improve error checking in PyTorch easyblock #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow easier testing by invoking it with some string
Also accepts a full build log in which case it tries to find the test output
Remove empty lines before matching
There is an extra line "If in CI, skip info is located in the xml test reports, please either go to s3 or the hud to download them" which throws of the matching. Include that.
The type hint for lists isn't valid until 3.9
boegel
changed the title
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
branfosj
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out functions extracting tests from the log from the test method to allow running them on log files for easier testing/debugging when they fail
Turns out in e.g. #3070 (comment) there are some extra newlines and an extra message which made the test fail. Handle that by a) removing any empty lines and checking for that extra line.