Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for Anaconda (anaconda.py) #3090

Merged
merged 1 commit into from Jan 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 27, 2024

(created using eb --new-pr)

  • EB_Anaconda used in Anaconda2, Anaconda3, Miniconda2, and Miniconda3
  • EB_Anaconda inherited by EB_Mamba

@branfosj branfosj modified the milestones: release after 4.9.0, 5.0 Jan 27, 2024
@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in anaconda.py replace run_cmd with run_shell_cmd in anaconda.py Jan 27, 2024
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Anaconda2-5.3.0.eb
  • SUCCESS Anaconda2-2019.10.eb
  • SUCCESS Anaconda3-2023.09-0.eb
  • SUCCESS Anaconda3-2018.12.eb
  • SUCCESS Miniconda3-23.9.0-0.eb
  • SUCCESS Miniconda3-4.5.12.eb
  • SUCCESS Miniconda2-4.7.10.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/31fa4757ff4a9c234a305b5082d723d2 for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Mamba-23.1.0-4.eb
  • SUCCESS Mamba-4.14.0-0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/57930a71c0e76b894e668c96eda3d64d for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 29, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x
EB_ARGS="Mamba-4.14.0-0.eb Anaconda2-2019.10.eb Anaconda3-2023.09-0.eb"

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in anaconda.py replace run_cmd with run_shell_cmd in custom easyblock for ADF (anaconda.py) Jan 29, 2024
@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in custom easyblock for ADF (anaconda.py) replace run_cmd with run_shell_cmd in custom easyblock for Anaconda (anaconda.py) Jan 29, 2024
@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3090 EB_ARGS="Mamba-4.14.0-0.eb Anaconda2-2019.10.eb Anaconda3-2023.09-0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3090 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3505

Test results coming soon (I hope)...

- notification for comment with ID 1914423994 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 29, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Mamba-4.14.0-0.eb
  • SUCCESS Anaconda2-2019.10.eb
  • SUCCESS Anaconda3-2023.09-0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node4003.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 535.129.03, Python 3.6.8
See https://gist.github.com/boegel/2c15779baeef3f372c61442e52d486e3 for a full test report.

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Mamba-4.14.0-0.eb
  • SUCCESS Anaconda2-2019.10.eb
  • SUCCESS Anaconda3-2023.09-0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/df27a97cdbc41b768df266f3f44039c1 for a full test report.

@boegel boegel merged commit 2d50f44 into easybuilders:5.0.x Jan 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240127095510_new_pr_anaconda branch January 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants