Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for ADF (adf.py) #3091

Merged
merged 2 commits into from Jan 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 27, 2024

(created using eb --new-pr)

I do not have the sources for this...

@branfosj branfosj added this to the 5.0 milestone Jan 27, 2024
@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in adf.py replace run_cmd with run_shell_cmd in adf.py Jan 27, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

changes are trivial enough to merge without test report, since installation files are not freely available (see 10647)

@boegel boegel changed the title replace run_cmd with run_shell_cmd in adf.py replace run_cmd with run_shell_cmd in custom easyblock for ADF (adf.py) Jan 29, 2024
@boegel boegel merged commit b96c726 into easybuilders:5.0.x Jan 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240127102156_new_pr_adf branch January 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants