Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for ANSYS (ansys.py) #3099

Merged
merged 1 commit into from Jan 29, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for ANSYS (ansys.py) #3099

merged 1 commit into from Jan 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 28, 2024 •
edited

(created using eb --new-pr)

  • No use of EB_ANSYS in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Jan 28, 2024
@branfosj branfosj mentioned this pull request Jan 28, 2024
Open
3 tasks
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS ANSYS-2022R2.eb
  • SUCCESS ANSYS-2023R1.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/0971cebd3f15175fc4e1743b6579911c for a full test report.

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in ansys.py replace run_cmd with run_shell_cmd in custom easyblock for ADF (ansys.py) Jan 29, 2024
@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in custom easyblock for ADF (ansys.py) replace run_cmd with run_shell_cmd in custom easyblock for ANSYS (ansys.py) Jan 29, 2024
boegel
boegel approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 208ae90 into easybuilders:5.0.x Jan 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240128151901_new_pr_ansys branch January 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@branfosj @boegel