Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for binutils (binutils.py) #3105

Merged
merged 1 commit into from Jan 29, 2024

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

@branfosj branfosj added this to the 5.0 milestone Jan 29, 2024
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.32.eb
  • SUCCESS binutils-2.34.eb
  • SUCCESS binutils-2.35.eb
  • SUCCESS binutils-2.36.1.eb
  • SUCCESS binutils-2.37.eb
  • SUCCESS binutils-2.38.eb
  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.40.eb
  • SUCCESS binutils-2.40-GCCcore-13.2.0.eb
  • SUCCESS binutils-2.40-GCCcore-12.3.0.eb
  • SUCCESS binutils-2.39-GCCcore-12.2.0.eb
  • SUCCESS binutils-2.38-GCCcore-11.3.0.eb
  • SUCCESS binutils-2.37-GCCcore-11.2.0.eb
  • SUCCESS binutils-2.36.1-GCCcore-10.3.0.eb
  • SUCCESS binutils-2.35-GCCcore-10.2.0.eb
  • SUCCESS binutils-2.34-GCCcore-9.3.0.eb

Build succeeded for 16 out of 16 (16 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/dc464845ccb66a5606b77cafe9e72fb1 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 29, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH="5.0.x"
EB_ARGS="binutils-2.39.eb binutils-2.40-GCCcore-13.2.0.eb --installpath /tmp/$USER/pr3105"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3105 EB_ARGS="binutils-2.39.eb binutils-2.40-GCCcore-13.2.0.eb --installpath /tmp/$USER/pr3105" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3105 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3510

Test results coming soon (I hope)...

- notification for comment with ID 1915192667 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS binutils-2.39.eb
  • SUCCESS binutils-2.40-GCCcore-13.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/bd7ab1617238fae1ab94fbc91bf999b8 for a full test report.

@boegel boegel merged commit 2e85c8c into easybuilders:5.0.x Jan 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240129125802_new_pr_binutils branch January 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants