Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for versions < 2.0 and replace run_cmd with run_shell_cmd in custom easyblock for ScaLAPACK (scalapack.py) #3106

Merged
merged 3 commits into from Jan 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 29, 2024

(created using eb --new-pr)

Oldest easyconfigs in the archive are for 2.x, so we should drop support for < 2.

…tom easyblock for scalapack (`scalapack.py`)
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS ScaLAPACK-2.2.0-gompi-2022b-fb.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/05114b045ac0329a966eeb86f5067f1f for a full test report.

easybuild/easyblocks/s/scalapack.py Outdated Show resolved Hide resolved
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 29, 2024

@boegelbot please test @ jsc-zen3
EB_BRANCH="5.0.x"
EB_ARGS="ScaLAPACK-2.2.0-gompi-2023b-fb.eb --installpath /tmp/$USER/pr3106"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3106 EB_ARGS="ScaLAPACK-2.2.0-gompi-2023b-fb.eb --installpath /tmp/$USER/pr3106" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3106 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3511

Test results coming soon (I hope)...

- notification for comment with ID 1915187920 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS ScaLAPACK-2.2.0-gompi-2023b-fb.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/258f6343e41d6a9324d1b4ad17693de6 for a full test report.

@boegel boegel merged commit b1aa48b into easybuilders:5.0.x Jan 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240129142434_new_pr_scalapack branch January 29, 2024 19:21
@boegel boegel changed the title drop support for <2 and replace run_cmd with run_shell_cmd in custom easyblock for scalapack (scalapack.py) drop support for versions < 2.0 and replace run_cmd with run_shell_cmd in custom easyblock for ScaLAPACK (scalapack.py) Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants