Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for Nim (nim.py) #3200

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 9, 2024

(created using eb --new-pr)

  • no use of EB_Nim in easyconfigs or blocks

@branfosj branfosj added this to the 5.0 milestone Feb 9, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 9, 2024
@branfosj
Copy link
Member Author

branfosj commented Feb 9, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Nim-1.4.8-GCCcore-10.3.0.eb
  • SUCCESS Nim-1.6.6-GCCcore-11.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/20b14c7b98638ae0b62ccb0cc423cee6 for a full test report.

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 3927bf6 into easybuilders:5.0.x Feb 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240209152741_new_pr_nim branch February 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants