Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only run CUDA sanity check command for torchvision if GPU is present #3236

Merged
merged 1 commit into from Mar 5, 2024
Merged

only run CUDA sanity check command for torchvision if GPU is present #3236

merged 1 commit into from Mar 5, 2024

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Feb 28, 2024 •
edited by Micket

(created using eb --new-pr)
fixes #2933

@boegelbot boegelbot mentioned this pull request Feb 28, 2024
Merged
@jfgrimm jfgrimm changed the title only run torchvision sanity check command test if GPU is present only run torchvision w/cuda sanity check command test if GPU is present Feb 28, 2024
@jfgrimm
Copy link
Member Author

jfgrimm commented Feb 28, 2024

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

  • SUCCESS torchvision-0.13.1-foss-2022a.eb
  • SUCCESS torchvision-0.11.3-foss-2021a-CUDA-11.3.1.eb
  • SUCCESS torchvision-0.11.3-foss-2021a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node091.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/54b981ea2cff7638ba93f09e06c7dfec for a full test report.

Micket
Micket approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Mar 2, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 2, 2024
@Micket Micket merged commit 093851c into easybuilders:develop Mar 5, 2024
47 checks passed
@boegel boegel changed the title only run torchvision w/cuda sanity check command test if GPU is present only run CUDA sanity check command for torchvision if GPU is present Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

torchvision sanity check requires a GPU
2 participants
@jfgrimm @Micket