New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed FoX constraint on GIPAW for QuantumESPRESSO easyblock #3258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I assume you rebuild the QEs but without |
Yes, i tried manually first and with an EB compiled version to run the example (without FoX). I've already edited the configs in my other PR (used in the test) and i think Alan will edit the 7.2 one in his (i edited the files to remove the with_fox for testing). |
The builds in easybuilders/easybuild-easyconfigs#20105 are passing just fine (the intel one needs a small tweak for a failing test, but this is not relevant to this PR) |
Test report by @Micket Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
I did successfully build without with_fox as a test, but i must have forgotten to upload test report. Anyway, it worked, so i'm happy with this change. |
Removing the requirement of compiling FoX in order to use GIPAW with QuantumESPRESSO >=7.2.
FoX has been made optional in QE from v7.2 (before 7.2 FoX is always compiled) and, as indicated in this commit, FoX has been removed as a dependency of GIPAW.
Tested by running one of the GIPAW examples with v7.2 intel/foss and 7.3 intel/foss from easyconfig PR #20070