Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set $GOPATH in configure step of GoPackage easyblock to avoid polluting $HOME/go #3262

Merged

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Mar 28, 2024

(created using eb --new-pr)

@Micket
Copy link
Contributor Author

Micket commented Mar 28, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS git-lfs-3.5.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/4ba6720d9892f7ca55c291b32b7aecd2 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Mar 28, 2024

Test report by @Micket

Overview of tested easyconfigs (in order)

  • SUCCESS rclone-1.66.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/9a196269a1afab30ed83b78fe7c8f707 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Mar 28, 2024

Can confirm my ~/go directory is nice and empty after this change!

@branfosj branfosj added this to the release after 4.9.0 milestone Mar 30, 2024
@branfosj
Copy link
Member

Can confirm my ~/go directory is nice and empty after this change!

So was mine. Thanks!

@branfosj
Copy link
Member

Going in, thanks @Micket!

@branfosj branfosj merged commit b5c161b into easybuilders:develop Mar 30, 2024
47 checks passed
@Micket Micket deleted the 20240328142407_new_pr_gopackage branch April 3, 2024 10:43
@boegel boegel changed the title Move Go build junk into builddir set $GOPATH in configure step of GoPackage easyblock to avoid polluting $HOME/go Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants